Skip to content

Conversation

cjgillot
Copy link
Contributor

I could not find a reason why the maximum length was this small.

@rust-highfive
Copy link
Contributor

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2021
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2021
@bors
Copy link
Collaborator

bors commented Apr 18, 2021

⌛ Trying commit 706c767 with merge a241652c9ec08b7a518ff4bace1692c9ea9bbf28...

@bors
Copy link
Collaborator

bors commented Apr 18, 2021

☀️ Try build successful - checks-actions
Build commit: a241652c9ec08b7a518ff4bace1692c9ea9bbf28 (a241652c9ec08b7a518ff4bace1692c9ea9bbf28)

@rust-timer
Copy link
Collaborator

Queued a241652c9ec08b7a518ff4bace1692c9ea9bbf28 with parent 6765010, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (a241652c9ec08b7a518ff4bace1692c9ea9bbf28): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 18, 2021
@cjgillot cjgillot closed this Apr 18, 2021
@cjgillot cjgillot deleted the spanlen branch October 17, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants